search

rec / safer

🧷 A safer writer 🧷
https://rec.github.io/safer/
MIT License
174 stars 9 forks source link

Possible logic error? #13

Closed rec closed 3 years ago

rec commented 3 years ago

Re-reading this code after a few months: how does self._close(False) ever get called?

https://github.com/rec/safer/blob/master/safer.py#L458

But if it doesn't get called, then how does everything work?

Everything seems to work - it's probably my misreading but the code should be cleaned up so it's clear how it works.

rec commented 3 years ago

Ah, it's pretty clear looking at the code in an editor. I'm closing this but will tweak comments next release.