Closed jhereth closed 2 years ago
β Merging this PR will increase code quality in the affected files by 2.04%.
Quality metrics | Before | After | Change |
---|---|---|---|
Complexity | 1.00 β | 1.00 β | 0.00 |
Method Length | 62.00 π | 59.00 β | -3.00 π |
Working memory | 13.00 π | 12.00 π | -1.00 π |
Quality | 68.39% π | 70.43% π | 2.04% π |
Other metrics | Before | After | Change |
---|---|---|---|
Lines | 33 | 32 | -1 |
Changed files | Quality Before | Quality After | Quality Change |
---|---|---|---|
setup.py | 68.39% π | 70.43% π | 2.04% π |
Here are some functions in these files that still need a tune-up:
File | Function | Complexity | Length | Working Memory | Quality | Recommendation |
---|
The emojis denote the absolute quality of the code:
The π and π indicate whether the quality has improved or gotten worse with this pull request.
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Help us improve this quality report!
Merging #17 (2cb378d) into master (85c53f9) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #17 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 259 259
Branches 57 63 +6
=========================================
Hits 259 259
Continue to review full report at Codecov.
Legend - Click here to learn more
Ξ = absolute <relative> (impact)
,ΓΈ = not affected
,? = missing data
Powered by Codecov. Last update 85c53f9...2cb378d. Read the comment docs.
Looks good to me! Thanks for doing this
I just pushed version 4.4.1 which fixes this issue (and also tweaks a few other configurations, noticeably losing support for 3.4-3.5 and adding it for 3.9 and 3.10).
setup.py
claims thatsafer.py
is an (executable) script.The docs say that "Scripts are files containing Python source code, intended to be started from the command line." and should have something like
#! /usr/bin/env python
in their first line.This is not the case for safer.py nor does this file contain any logic to be executed when called from the command line.
This change removes this entry.
fixes #16