rec / safer

🧷 A safer writer 🧷
https://rec.github.io/safer/
MIT License
174 stars 10 forks source link

don't install setup.py as script #17

Closed jhereth closed 2 years ago

jhereth commented 2 years ago

setup.py claims that safer.py is an (executable) script.

The docs say that "Scripts are files containing Python source code, intended to be started from the command line." and should have something like #! /usr/bin/env python in their first line.

This is not the case for safer.py nor does this file contain any logic to be executed when called from the command line.

This change removes this entry.

fixes #16

sourcery-ai[bot] commented 2 years ago

Sourcery Code Quality Report

βœ…  Merging this PR will increase code quality in the affected files by 2.04%.

Quality metrics Before After Change
Complexity 1.00 ⭐ 1.00 ⭐ 0.00
Method Length 62.00 πŸ™‚ 59.00 ⭐ -3.00 πŸ‘
Working memory 13.00 😞 12.00 😞 -1.00 πŸ‘
Quality 68.39% πŸ™‚ 70.43% πŸ™‚ 2.04% πŸ‘
Other metrics Before After Change
Lines 33 32 -1
Changed files Quality Before Quality After Quality Change
setup.py 68.39% πŸ™‚ 70.43% πŸ™‚ 2.04% πŸ‘

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

The πŸ‘ and πŸ‘Ž indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

codecov[bot] commented 2 years ago

Codecov Report

Merging #17 (2cb378d) into master (85c53f9) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #17   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          259       259           
  Branches        57        63    +6     
=========================================
  Hits           259       259           

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 85c53f9...2cb378d. Read the comment docs.

rec commented 2 years ago

Looks good to me! Thanks for doing this

rec commented 2 years ago

I just pushed version 4.4.1 which fixes this issue (and also tweaks a few other configurations, noticeably losing support for 3.4-3.5 and adding it for 3.9 and 3.10).