Sourcery Code Quality Report

❌ Merging this PR will decrease code quality in the affected files by 0.01%.

Quality metrics	Before	After	Change
Complexity	4.93 ⭐	4.93 ⭐	0.00
Method Length	52.38 ⭐	52.42 ⭐	0.04 👎
Working memory	4.85 ⭐	4.85 ⭐	0.00
Quality	77.20% ⭐	77.19% ⭐	-0.01% 👎

Other metrics	Before	After	Change
Lines	1373	1405	32

Changed files	Quality Before	Quality After	Quality Change
safer.py	55.77% 🙂	55.73% 🙂	-0.04% 👎
setup.py	87.94% ⭐	87.94% ⭐	0.00%
test/get_help.py	93.32% ⭐	93.32% ⭐	0.00%
test/test_doc.py	92.21% ⭐	92.21% ⭐	0.00%
test/test_dump.py	89.39% ⭐	89.39% ⭐	0.00%
test/test_files.py	88.22% ⭐	88.22% ⭐	0.00%
test/test_open.py	82.01% ⭐	82.01% ⭐	0.00%
test/test_printer.py	84.18% ⭐	84.18% ⭐	0.00%
test/test_writer.py	89.08% ⭐	89.08% ⭐	0.00%

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
safer.py	open	32 😞	329 ⛔		16.74% ⛔	Refactor to reduce nesting. Try splitting into smaller methods
safer.py	writer	28 😞	231 ⛔	14 😞	26.85% 😞	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
safer.py	dump	24 😞	183 😞	9 🙂	41.27% 😞	Refactor to reduce nesting. Try splitting into smaller methods
test/test_open.py	TestSafer.test_two_errors	5 ⭐	222 ⛔	8 🙂	56.18% 🙂	Try splitting into smaller methods
safer.py	_FileCloser._make_stream	7 ⭐	137 😞	8 🙂	61.72% 🙂	Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

rec commented 1 year ago

I would want to merge this, except it takes my sorted imports and unsorts them!