rec / safer

🧷 A safer writer 🧷
https://rec.github.io/safer/
MIT License
174 stars 9 forks source link

Move Black to be dev dependency (or remove it entirely) #24

Closed owenlamont closed 8 months ago

owenlamont commented 8 months ago

For some reason Black has been added as a primary dependency instead of a dev dependency in the poetry config.

This means pip installing safer unnecessarily installs Black into the local Python environment and the corresponding conda-forge recipe are unnecessarily installing Black at runtime now too.

P.S.

Since you already install Ruff as a dev dependency I was going to suggest removing the Black dependency entirely and using the near identical (depending on the config) Ruff formatter.

rec commented 8 months ago

Ooops, I know why this happened (a boring mistake).

I'll get to this first thing tomorrow AM!

On Sun, Jan 14, 2024 at 10:24 PM Owen Lamont @.***> wrote:

For some reason Black has been added as a primary dependency instead of a dev dependency in the poetry config.

This means pip installing safer unnecessarily installs Black into the local Python environment and the corresponding conda-forge recipe https://github.com/conda-forge/safer-feedstock/blob/main/recipe/meta.yaml are unnecessarily installing Black at runtime now too.

P.S.

Since you already install Ruff as a dev dependency I was going to suggest removing the Black dependency entirely and using the near identical (depending on the config) Ruff formatter https://docs.astral.sh/ruff/formatter/.

— Reply to this email directly, view it on GitHub https://github.com/rec/safer/issues/24, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAB53MQU6A62UT4K3ATXO2DYOREKDAVCNFSM6AAAAABB2L674SVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA4DAOJQGMZTOMI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- /t

PGP Key: @.** https://tom.ritchford.com https://tom.ritchford.com https://tom.swirly.com https://tom.swirly.com*

rec commented 8 months ago

Fixed!, in v4.12.3

Thanks for finding this, what a silly mistake.

If you like this library, you might also like https://github.com/rec/tdir or https://github.com/rec/editor

Have a great week, don't hesitate to ask if you have any problems or feature suggestions!

owenlamont commented 8 months ago

You're welcome, love seeing the greater Ruff use. I'm a big fan of Ruff.