Export Selection As Audio File... exports too much for discontiguous selection

[wsirota]

I never thought I'd see anyone actually complain about this, but Jeff Lyon did (From: Jeff Lyon jefflyon@cox.net Date: Sat, Jan 28, 2017 at 10:17 AM).

Steps to reproduce:

1. create a few loop points in a file, so that there are at least 2 short discontiguous segments that can be selected simultaneous.
2. Select Export Selection As Audio File... from the file menu and perform the export

Expected: new file opens containing the two selected segments

Actual new file opens containing multiple copies of the two selected segments, concatenated

Bug severity: one customer has a complaint, but surely this is an extreme edge case.

[rec]

COOL!

I'll try to get on this, particularly since we have a complaint. Is he Windows - only downside?

On 31 January 2017 at 23:42, wsirota notifications@github.com wrote:

Assigned #718 https://github.com/rec/rec/issues/718 to @rec https://github.com/rec.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rec/rec/issues/718#event-943930435, or mute the thread https://github.com/notifications/unsubscribe-auth/AAPdsn8QbpWIUm-ua7kJ5j7yDAtS65GTks5rX7jXgaJpZM4LzRPt .

-- /t

http://radio.swirly.com - art music radio 24/7 366/1000

[rec]

So I spent a little time on this without luck. There is evidence in the code that I knew there was an issue already :-(

https://github.com/rec/rec/blob/develop/src/rec/audio/source/Selection.cpp#L31-L38

Unfortunately, turning on CORRECT_SIZE_CALCULATIONS makes it even worse - instead of a result on export it just hangs forever.