search

recast-hep / recast-atlas

CLI for ATLAS RECAST contributors
https://recast.docs.cern.ch/
Apache License 2.0
6 stars 5 forks source link

Get testing of built Docker image working in CI #50

Open matthewfeickert opened 2 years ago

matthewfeickert commented 2 years ago

this seemss to be too deeeply nested docker (note it mounts docker.sock which might not be avaliable on GHA). c.f. https://github.com/maxheld83/ghactions/issues/307

_Originally posted by @lukasheinrich in https://github.com/recast-hep/recast-atlas/pull/46#discussion_r712279409_

matthewfeickert commented 2 years ago

Ah, as a note to myself on understanding how recast is running Docker in Docker, it is mounting the socket /var/run/docker.sock

https://github.com/recast-hep/recast-atlas/blob/93370713c8c41a8d6386ce3595a8fdf7f44c8112/src/recastatlas/backends/docker.py#L28-L39

and so relying on the host to provide Docker. :+1: