search

recast-hep / recast-atlas

CLI for ATLAS RECAST contributors
https://recast.docs.cern.ch/
Apache License 2.0
6 stars 5 forks source link

build: Require setuptools<58.0.0 for reana extra #52

Closed matthewfeickert closed 2 years ago

matthewfeickert commented 2 years ago

Requires PR #46 to go in first.

reana-client v0.7.5 has a dependency on cwltool==1.0.20191022103248 which apparently has conflicts with setuptools v58.0.0 and later, presumably from the breaking changes that were introduced of

Removed support for 2to3 during builds. Projects should port to a unified codebase or pin to an older version of Setuptools using PEP 518 build-requires.

The release of reana-client v0.8.0 will fix this and the setuptools restriction will be able to be removed.

c.f. reanahub/reana-client#558

matthewfeickert commented 2 years ago

Example of things working with the setuptools restriction:

$ docker run --rm -ti python:3.8-bullseye /bin/bash
root@6c360a04ef6a:/# python -m venv example && . example/bin/activate
(example) root@6c360a04ef6a:/# python -m pip --quiet install --upgrade pip "setuptools<58.0.0" wheel
(example) root@6c360a04ef6a:/# pip list
Package    Version
---------- -------
pip        21.2.4
setuptools 57.5.0
wheel      0.37.0
(example) root@6c360a04ef6a:/# git clone https://github.com/recast-hep/recast-atlas.git && cd recast-atlas
(example) root@6c360a04ef6a:/recast-atlas# git checkout 4eba02ea6678f253a9bb578cf70385d01b581f32  # HEAD of master when this PR was opened
(example) root@6c360a04ef6a:/recast-atlas# python -m pip install .[reana]
(example) root@6c360a04ef6a:/recast-atlas# pip freeze | grep "reana"
reana-client==0.7.5
reana-commons==0.7.5
(example) root@6c360a04ef6a:/recast-atlas#
matthewfeickert commented 2 years ago

@lukasheinrich This is ready for review.