search

receipt-print-hq / escpos-tools

Utilities to read ESC/POS print data
MIT License
200 stars 73 forks source link

PHP53 support #43

Closed tmsdnl closed 6 years ago

tmsdnl commented 6 years ago

Updated array shorthand [] to array() to support PHP 5.3, ignoring .DS_Store

mike42 commented 6 years ago

Welcome, thanks to the pull request.

I'm going to merge so that I can point users of PHP 5.3 to this to this version in the future.

Since PHP 5.3 so old, and we don't test on it, you can expect that it will stop working as we add dependencies on things like PHPUnit. Accordingly, PHP 5.6 is is named in the README as the minimum version to use with this code, and it's probably a bug that we aren't using composer to enforce that. See also #4.

I'll note that PHP 5.3 users account for 0.76% of composer installs and falling[1]. If you are using it, upgrade!

[1] https://seld.be/notes/php-versions-stats-2017-2-edition

tmsdnl commented 6 years ago

Hi @mike42

This all makes sense.

The reason I've pushed these small fixes is that I've been working on Epson TM-T88VI with a built-in PHP53 server.

I hope Epson is going to upgrade soon.

Cheers again Tomas