receyuki / comfyui-prompt-reader-node

The ultimate solution for managing image metadata and multi-tool compatibility. ComfyUI node version of the SD Prompt Reader
MIT License
289 stars 22 forks source link

[BUG] - %counter overwriting #14

Closed Tirshea closed 1 year ago

Tirshea commented 1 year ago

Description

ComfyUI: When using %counter in the filename, it will overwrite existing images. Basically %counter will reset to 0 everytime you queue up a render.

Result : When you queue X iterations with Batch_Size = Y, you will have Y images at the end, with %counter values from 0 to Y

Suggestion : have it work like the basic SaveImage node, where you supply the path&filename, and the counter is automatically added and incremented based on existing images with that filename at target path.

Reproduction steps

No response

Image file

No response

Version

1.3.4

OS

Windows

Tool

A1111's webUI

receyuki commented 1 year ago

Please submit issues related to the ComfyUI node version in the node version repo next time, thx.

About this issue, you’re right, there were some bugs with the counter in the previous version, but they have been fixed in the current version. Please update your node version to the newest and try again. When starting ComfyUI, the version number of the Prompt Reader Node will be displayed in the terminal (cmd or powershell). This problem should occur in 1.0.0beta3, and is fixed in 1.0.0 (no suffix). If the issue persists, please let me know.

Tirshea commented 1 year ago

ah yes, sorry I went on the wrong page.

I think I have the right version though: image

I have circumvented the issue by using a separate counter and some string concatenation to achieve the same result.

receyuki commented 1 year ago

I just retested and found that %counter still has some bugs, but this bug is quite complex, so please consider using alternatives like %time for now. I will fix this bug later.

receyuki commented 1 year ago

Fixed in v1.0.1, please update the node to the latest version.

Tirshea commented 1 year ago

Fix confirm, thanks for your effort !