receyuki / comfyui-prompt-reader-node

The ultimate solution for managing image metadata and multi-tool compatibility. ComfyUI node version of the SD Prompt Reader
MIT License
283 stars 22 forks source link

[FEATURE REQUEST] - Clip Skip in Parameter Generator node #55

Open Latentnaut opened 9 months ago

Latentnaut commented 9 months ago

Summary

Just wanted to say congratulations for this package, it's amazing to have all parameters in (almost) one node. I only miss Clip Skip to complete the whole thing. Have you ever think about it? Thank you this marvellous job.

Basic Example

Clip Skip in SD Parameter Generator.

Reference Issues.

No response

receyuki commented 8 months ago

Thank you for your feedback. About the selection of parameters, I personally tend to choose the most commonly used ones. Clip Skip, however, seems to be less common. I would recommend placing a primitive node next to the Parameter Generator node and connecting it to the stop_at_clip_layer. What do you think? Of course, if more users believe Clip Skip is necessary, I will add it to the parameters.

截屏2024-02-06 下午8 52 47
receyuki commented 8 months ago

BTW, please post issues related to the comfyui node to another repo next time.

Latentnaut commented 8 months ago

I understand you want to keep the esencial parameters in one place. Otherwise it could be overwhelming for some user.

But hey, this node suppose to be to more advanced users, in my opinion.

For me perspective, adding one parameter more would help me to clean my starter models.

One solution could be creating two types of SD Parameter Generator: standard and extensive. First one like the current one and the second with more parameters. It reminds me the amazing Context and Context Big nodes from rgthree

But, hey, this is a lot of work, I really appreciate the current state.

Peace and love

receyuki commented 8 months ago

In fact, the current parameter generator is already an advanced version. I have considered making a simpler version, but it wouldn't make everyone's life easier, it would only increase my workload.

Anyway, I will keep this issue open.