[BUG] - the scheduler from SD Parameter Generator cannot connect to Ksampler or any other node which has scheduler as an input

receyuki / comfyui-prompt-reader-node

The ultimate solution for managing image metadata and multi-tool compatibility. ComfyUI node version of the SD Prompt Reader

MIT License

289 stars 22 forks source link

[BUG] - the scheduler from SD Parameter Generator cannot connect to Ksampler or any other node which has scheduler as an input #81

Closed jinxishe closed 4 months ago

jinxishe commented 4 months ago

Description

the scheduler from SD Parameter Generator cannot connect to Ksampler or any other node which has scheduler as an input. It seems happen with recent ComfyUI Update.

Reproduction steps

No response

Image file

scheduler

receyuki commented 4 months ago

Everything is working fine on my end. I also checked the latest updates for ComfyUI, and it doesn't seem like there are any commits related to KSampler. My suggestion is to restart the ComfyUI, refresh the webpage, and delete and re-add both nodes.

robertwaleda commented 4 months ago

Unfortunately I have the same issue. Sometimes the connection between SD Parameter generator and a KSampler is not possible. But then with another tryout, it is connected. Then when running a queue, no scheduler input at Sampler (red circle). I have found that the scheduler output of the SD Parameter Generator is not present. If I change the scheduler input widget from KSampler back, and choose a scheduler name, then Sampler is working fine. So my first impression is that this is a bug within SD Parameter Generator, using the most recent updated ComfyUI. I have already re-added the node, but problem still exists. For the record, I have a Mac Studio M2 Max.

jinxishe commented 4 months ago

I forgot where I saw it, but it seems that a recent update to ComfyUI made adjustments to scheduler-related functions. All custom nodes involving the scheduler might need some modifications. However, I can't remember the specific details, so I apologize for that.

Everything is working fine on my end. I also checked the latest updates for ComfyUI, and it doesn't seem like there are any commits related to KSampler. My suggestion is to restart the ComfyUI, refresh the webpage, and delete and re-add both nodes.

receyuki commented 4 months ago

@robertwaleda @jinxishe Have any other custom nodes had similar issues recently? I can’t figure out what the problem is.

jinxishe commented 4 months ago

@robertwaleda @jinxishe Have any other custom nodes had similar issues recently? I can’t figure out what the problem is.

yes. other custom nodes like Impact Scheduler Adapter(from Impact Pack) and XY Input:Sampler/Scheduler(from Efficiency Node) have same problems.

3207ece2-2a66-4e14-a86c-e11f7250ce34

jinxishe commented 4 months ago

@robertwaleda @jinxishe Have any other custom nodes had similar issues recently? I can’t figure out what the problem is.

yes. other custom nodes like Impact Scheduler Adapter(from Impact Pack) and XY Input:Sampler/Scheduler(from Efficiency Node) have same problems.

3207ece2-2a66-4e14-a86c-e11f7250ce34

receyuki commented 4 months ago

@robertwaleda @jinxishe Have any other custom nodes had similar issues recently? I can’t figure out what the problem is.

yes. other custom nodes like Impact Scheduler Adapter(from Impact Pack) and XY Input:Sampler/Scheduler(from Efficiency Node) have same problems.

If the authors of these nodes can figure out the problem and solution, I should be able to use it as a reference.

jinxishe commented 4 months ago

@robertwaleda @jinxishe Have any other custom nodes had similar issues recently? I can’t figure out what the problem is.

yes. other custom nodes like Impact Scheduler Adapter(from Impact Pack) and XY Input:Sampler/Scheduler(from Efficiency Node) have same problems.

If the authors of these nodes can figure out the problem and solution, I should be able to use it as a reference.

I got some interesting result. When I disabled the Efficiency Node, the problem disappeared. Seems like the AYS-xxxx schedulers added by Efficiency Node caused the problem. I will check the Efficiency Node's issues. Thanks a lot!

jinxishe commented 4 months ago

I confirmed it's the Efficiency Node's bug. And it's been fixed recently.(https://github.com/jags111/efficiency-nodes-comfyui/pull/210) After update to newest code, everything is OK now. Thanks again. I'll close this issue.

jinxishe commented 4 months ago

Unfortunately I have the same issue. Sometimes the connection between SD Parameter generator and a KSampler is not possible. But then with another tryout, it is connected. Then when running a queue, no scheduler input at Sampler (red circle). I have found that the scheduler output of the SD Parameter Generator is not present. If I change the scheduler input widget from KSampler back, and choose a scheduler name, then Sampler is working fine. So my first impression is that this is a bug within SD Parameter Generator, using the most recent updated ComfyUI. I have already re-added the node, but problem still exists. For the record, I have a Mac Studio M2 Max.

If you used the Efficiency Node, try to update to newest code and it should fix the problem.

receyuki commented 4 months ago

Looks like my version of Efficiency Node is too old, which is why this bug didn't appear.

robertwaleda commented 4 months ago

Just tested the scheduler connection between SD Parameter Generator and the KSampler from Efficiency Nodes. The issue is still present. As a temporary workaround, I now use the native scheduler from the KSampler node, as this is also advised by the maintainer ( see https://github.com/jags111/efficiency-nodes-comfyui/issues/208 ). So I think that this case can be closed, because in fact it has to be addressed as an issue with Efficiency Nodes. Thanks for your help.

robertwaleda commented 4 months ago

Extra info: The last update of the Efficiency nodes on my Mac has been done on June 24th. So I suppose that the 210 patch is included.