search

receyuki / stable-diffusion-prompt-reader

A simple standalone viewer for reading prompts from Stable Diffusion generated image outside the webui.
MIT License
1.06k stars 69 forks source link

[BUG] - does not always correctly read the seed from ComfyUI #33

Closed lilixil closed 1 year ago

lilixil commented 1 year ago

Example: ComfyUI_01807_
You can drag the file into ComfyUI and see that it has a seed that allows you to recreate the same generated image. You can find seed in this file ("noise_seed": 1058386025918295), and stable-diffusion-prompt-reader showing Seed: None.

obraz

When i changed control_after_generate from randomized to fixed and use 1058386025918295 as a noise_seed (in KSampler Advanced - BASE) i can generate basically the same picture, so it has a seed.

ComfyUI_01850_

I downloaded stable-diffusion-prompt-reader mainly for this, it would be nice if you would create an update.

receyuki commented 1 year ago

It seems like you are using SDXL, which is not currently supported. I will add support for SDXL in the next release.

Tikishark777 commented 1 year ago

Do you have an estimate of when you think the next release will be available? TY

receyuki commented 1 year ago

You seem to be in a hurry, so I've made a temporary version for you to fix this issue. But the next release may still take a few days (I've been drinking too much these days). If you don't experience any problems, you can use it as a normal version and update it as usual. SD-Prompt-Reader-1.3.2a2.dev1-Windows-x64.zip

Tikishark777 commented 1 year ago

Thank you. I can totally wait for the full version. Enjoy the summer and drink up : )

lilixil commented 1 year ago

You seem to be in a hurry, so I've made a temporary version for you to fix this issue. But the next release may still take a few days (I've been drinking too much these days). If you don't experience any problems, you can use it as a normal version and update it as usual. SD-Prompt-Reader-1.3.2a2.dev1-Windows-x64.zip # Now the seed values ​​for the photo in question are shown correctly. Thanks!

I've identified another issue (which also occurs in the latest version, 1.3.3-beta.1 and also 1.3.3-beta.1+dev.1) - when you open the images below using the program, the positive prompt is not visible. (edit: I've noticed that the issue has already been noted here) ComfyUI_01938_ ↑ ComfyUI01938.zip ↑

ComfyUI_01964_ ↑ ComfyUI01964.zip ↑

Btw 1, it would be ok if the "Scheduler" were also displayed in the 3rd window in Simple mode view, although it's not really crucial.

Btw 2, a somewhat facilitating feature for working with the program would be displaying the name of the open file, e.g. below/above the image or in the top bar.

receyuki commented 1 year ago

@lilixil This bug is the same as the bug with the norwegian forest cat, so it will also be fixed in beta2.

My idea is that the simple mode should display parameters that are common to all tools by default and are most commonly used by the majority of users. However, for most of the tools, the option to modify the scheduler is not displayed by default. Later on, I will add a user preferences interface. At that time, I can include an option to customize the content displayed in the simple mode.

In the upcoming gallery view mode mentioned in #31, the file name, modification time, and size of the images will be displayed. But honestly, in the current UI, I'm not sure where to place the file name. It feels like displaying it anywhere wouldn't be very aesthetically pleasing.

receyuki commented 1 year ago

@lilixil https://github.com/receyuki/stable-diffusion-prompt-reader/releases/tag/v1.3.3-beta.2 I just released beta 2. Try it out.

lilixil commented 1 year ago

@receyuki v1.3.3-beta.2 solved the problem, thank you.

In terms of the aesthetics of the filename placement, I think that what it looks like here is the most aesthetic way. It may look the same when displaying a single photo, not a gallery.

receyuki commented 1 year ago

@lilixil In my opinion, when you drag in a single image, you should know which image you've dragged in. However, when you drag in multiple images, you might need the file names to distinguish them. So, when displaying a single image, the file name might not be very necessary. What do you think?

lilixil commented 1 year ago

@receyuki I agree that when dragging a single image I should know which one I dragged. However, when I do many things at once, while having several hundred photos in the folder, this one name of the file displayed in the program may escape from memory and then i have to scroll the folder again. For me personally, this would be a useful feature. Maybe you could include an optional display of the filename for a single file in the program options.

receyuki commented 1 year ago

@lilixil Alright, I'll take that into consideration.