search

recharts / react-smooth

react animation
MIT License
277 stars 38 forks source link

chore(deps): add react 17 to peer deps #46

Closed Zertz closed 3 years ago

Zertz commented 3 years ago

This will suppress messages similar to this:

warning "recharts > react-smooth@1.0.6" has incorrect peer dependency "react@^15.0.0 || ^16.0.0".
warning "recharts > react-smooth@1.0.6" has incorrect peer dependency "react-dom@^15.0.0 || ^16.0.0".
bradtgmurray commented 3 years ago

FYI I also made the same change in #47 and confirmed that npm demo was happy when running with react 17.

semoal commented 3 years ago

@xile611 can we move this to base branch please?

Zertz commented 3 years ago

Without the ability to run Enzyme tests with React 17, it's understandable the maintainers may not want to merge this just yet.

On our end, it's just the minor annoyance of a few warnings.

semoal commented 3 years ago

Without the ability to run Enzyme tests with React 17, it's understandable the maintainers may not want to merge this just yet.

On our end, it's just the minor annoyance of a few warnings.

That's not a problem. https://github.com/recharts/react-smooth/pull/48 I've refactored the testing suite to use jest with testing-library and React 17, tests passed correctly and everything is working fine.

;)

cmmartin commented 3 years ago

Is this released? I'm getting an error using the latest version of recharts with react 17.

npm ERR! Could not resolve dependency:
npm ERR! peer react@"^15.0.0 || ^16.0.0" from react-smooth@1.0.6
npm -v
7.0.15
semoal commented 3 years ago

This not released yet. Sorry