recharts / react-smooth

react animation
MIT License
277 stars 38 forks source link

Upgrade dependencies #72

Closed ckifer closed 1 year ago

ckifer commented 1 year ago

This library is in need of some dependency upgrades (see dependabot PRs) to stay up to date and to prepare for upgrading react-transition-group and dropping support for react < 16.8. This is a release candidate for 2.0.2.

Note:

Tests are passing - linter is not. It wasn't before either.

Also released this to my personal NPM to test in recharts - https://www.npmjs.com/package/ckifer-react-smooth

Semigradsky commented 1 year ago

Just a suggestion: replace fast-equals to fast-deep-equal to potentially decrease count of dependencies. For example my project already has fast-deep-equal from eslint, ajv, bonjour-service (webpack-dev-server dependency)

ckifer commented 1 year ago

Maybe makes sense to do before releasing the next major version yeah. But you're right fast-deep-equals is much more used/popular.

For now I was just cleaning up dependencies so things are up to date. Feel free to make a PR if you'd like to replace it!

Semigradsky commented 1 year ago

I rechecked packages and maybe switch to fast-deep-equal is not good decision. fast-equals is better maintained and has no problems with objects with null prototype. Potentially fast-equals is better choise.