search

recharts / react-smooth

react animation
MIT License
277 stars 38 forks source link

Remove translateStyle function and export #82

Closed PavelVanecek closed 11 months ago

PavelVanecek commented 11 months ago

This was necessary in 2017 but is not needed anymore - all browsers now support CSS transforms and transitions without prefixes.

This is a breaking change. The function export was not documented but I guess if it's exported from index then it's part of the public API. Recharts will break for example :)

https://caniuse.com/?search=transforms

Also discussed on Slack: https://recharts.slack.com/archives/C042Q5K5UDC/p1697529536898929

ckifer commented 11 months ago

Although... in the spirit of semver we could just do a major version release of react-smooth for consumers and accept it as 'non-breaking' for recharts

PavelVanecek commented 11 months ago

I'm not fussed about browser support but in this PR I have removed a function export - that's the breaking part.

ckifer commented 11 months ago

Oh yeah makes sense, we can do that