fix new object comparison logic bug

recharts / react-smooth

react animation

MIT License

277 stars 38 forks source link

fix new object comparison logic bug #89

Closed ngraef closed 5 months ago

ngraef commented 6 months ago

Resolves #88

The bug was introduced in https://github.com/recharts/react-smooth/commit/6d07641123cbdce3d4e24f280e032b78fb5ca377#diff-14c3c6f167ed693f239ff4934d5695ca6c5e70a713b3ecd7afdc5239b4412d5dL151-R100.

I don't know enough about this library to know how to test this fix and its impact to users. Help would be appreciated if that is required before merge.

ngraef commented 5 months ago

@ckifer would you mind reviewing?

ckifer commented 5 months ago

Sure sorry, I didn't get any notifications for this for whatever reason