test(reference-line): add test that will fail if we remove defaultProps

ckifer commented 3 weeks ago

Description

Add unit test that will fail when defaultProps are removed for referenceline. Realized that it seems everything is peachy still when I went to try to remove them again. Nope, still broken and this shows it

Related Issue

Don't really want to link the defaultProps issue

Motivation and Context

testsss

How Has This Been Tested?

tests pass

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I have added tests to cover my changes.
[ ] I have added a storybook story or extended an existing story to show my changes

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.41%. Comparing base (b37ea34) to head (551b95e).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## 3.x #4497 +/- ## ======================================= Coverage 95.41% 95.41% ======================================= Files 111 111 Lines 21509 21509 Branches 2988 2988 ======================================= Hits 20522 20522 Misses 981 981 Partials 6 6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

PavelVanecek commented 3 weeks ago

I didn't even know it does that!

ckifer commented 3 weeks ago

Yeah it matches reference items to axis ids and then for each reference item looks to see if it needs to extend the domain.

I started writing the context but it's weird with everything being done inside the generator before any info is even passed to the components

recharts / recharts