recharts / recharts

Redefined chart library built with React and D3
http://recharts.org
MIT License
22.95k stars 1.67k forks source link

Area + Bar send their tooltip data to redux store #4521

Closed PavelVanecek closed 2 weeks ago

PavelVanecek commented 3 weeks ago

Description

Following up on the idea from https://github.com/recharts/recharts/pull/4518

This is still failing tests - to start actually using the Redux data in Tooltip, I need to migrate the tooltipAxis next.

Related Issue

https://github.com/recharts/recharts/discussions/3717

Motivation and Context

No element cloning.

How Has This Been Tested?

npm test

Screenshots (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.50%. Comparing base (ee9e75a) to head (3cf532a).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 3.x #4521 +/- ## ========================================== + Coverage 95.49% 95.50% +0.01% ========================================== Files 113 113 Lines 21892 21981 +89 Branches 3021 3029 +8 ========================================== + Hits 20905 20994 +89 Misses 981 981 Partials 6 6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.