Moving Axes to Redux - Githubissues

PavelVanecek commented 2 weeks ago

Description

One step closer in my quest of rendering Tooltip from Redux store alone.

Tooltip is not yet functional - for that it needs Tooltip.shared and Scatter - but it's almost there. Builds are green so I figured we might as well merge it.

Motivation and Context

No direct DOM access

How Has This Been Tested?

npm test

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] I have added a storybook story or extended an existing story to show my changes

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 99.63899% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 95.52%. Comparing base (139a587) to head (c10c7f1). Report is 2 commits behind head on 3.x.

Files	Patch %	Lines
src/state/selectors.ts	98.41%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## 3.x #4524 +/- ## ========================================== + Coverage 95.51% 95.52% +0.01% ========================================== Files 113 116 +3 Lines 22004 22101 +97 Branches 3034 3045 +11 ========================================== + Hits 21017 21113 +96 - Misses 981 982 +1 Partials 6 6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ckifer commented 2 weeks ago

Nice

recharts / recharts

Moving Axes to Redux #4524