recharts / recharts

Redefined chart library built with React and D3
http://recharts.org
MIT License
22.95k stars 1.67k forks source link

Move two functions to separate file, add types #4530

Closed PavelVanecek closed 2 weeks ago

PavelVanecek commented 2 weeks ago

I started with huge ambitions here (as evidences by the branch name) but quickly ran out of steam. Everything depends on everything, I don't see a path forward here.

What I did here is a small improvement and ready to merge but it's not a breathtaking change.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.53%. Comparing base (78a851e) to head (ee93552).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 3.x #4530 +/- ## ======================================= Coverage 95.52% 95.53% ======================================= Files 116 116 Lines 22100 22140 +40 Branches 3045 3046 +1 ======================================= + Hits 21112 21152 +40 Misses 982 982 Partials 6 6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.