Closed eps1lon closed 2 weeks ago
uhh I think this PR was made from the wrong branch. Can you try switching to 3.x and then make the change?
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.56%. Comparing base (
85b29df
) to head (0051d8c
). Report is 3 commits behind head on 3.x.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
Make
react-is
a peer dependency instead of a direct dependencyRelated Issue
Motivation and Context
react-is
needs to be the same version as the used version of React. So far these dependencies could be out of sync since the related internals didn't changed. However, in React 19 related internals did change. Usingreact-is<19
would not recognize elements fromreact>=19
and vice versa. So generally,react-is
should be installed by library users just like React. That way, users can make sure the versions match without having to resort toresolutions
oroverrides
which wouldn't even work for libraries.How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: