search

recipeswithbackbone / recipeswithbackbone.github.com

Marketing site for the best damn backbone.js book evar
23 stars 1 forks source link

Page 62: Code Typo #39

Closed simax closed 12 years ago

simax commented 12 years ago

The second code snippet on page 62 displays the MonthCounts collection. The first property it sets is the tagName, surely tagName is a UI concern (a views concern) and should not be present in the MonthCounts collection. I believe it should be set on the View.MonthsCount definition on page 63.

Collections.MonthCounts = Backbone.Collection.extend({ tagName: 'ul', model: Models.MonthCount, initialize: function(models, options) { ...

eee-c commented 12 years ago

Will double-check that one. I don't know how a tagName could have gotten into a collection, but that definitely looks wrong...

eee-c commented 12 years ago

Yah, that didn't make any sense. Not sure how that got in there, but thanks for noticing :)

eee-c commented 12 years ago

Fixed in latest. Download from the same link in the original purchase email.