search

reckel-jm / cantara

Open Source Simple Song Presentation Software
https://www.cantara.app
GNU General Public License v3.0
13 stars 6 forks source link

Wrong display of presentation when no specific font has been selected #24

Closed reckel-jm closed 7 months ago

reckel-jm commented 8 months ago

Describe the bug User @fartleako has reported that on Windows 11 there seems to be an error of displaying songs when no specific font has been selected in the settings.

To Reproduce Steps to reproduce the behavior (if known):

  1. Run Cantara without specific font configuration
  2. Select a song
  3. Start the presentation

Expected behavior The lyrics should not be cropped like they are in the screenshot.

Screenshots grafik

Information about your Operation System (please complete the following information):

reckel-jm commented 8 months ago

Diagnosis: It seems that the calculation of the vertical font size for the surrounding TextRect leads to wrong results if no font is specified and the system default is going to be used. In order to change that, I will hard code 'Arial' as the default if no specific font has been set.

reckel-jm commented 8 months ago

1daffb21b14463b6629c2f8ff012967fc574ec81 should fix the problem. I will test it on Windows and then close the issue.

reckel-jm commented 7 months ago

Hello @fartleako, I have tested it under Windows 11 (the only Windows I have access to at the moment) and there has been no problems in display. See the picture below. I'll mark the topic as solved for now. If any problems still arise, feel free to open it again. Alles, was ihr tut