search

reclaim-the-stack / talos-manager

Rails application to help bootstrap Talos Linux on Hetzner servers
MIT License
32 stars 10 forks source link

Heroku default subdomain Host fix #8

Closed gunnars04 closed 3 months ago

gunnars04 commented 3 months ago

I found a bug in the readme.md - I made a fix

I forked the project and created a branch with the fix (I tried it, it works):

Before the fix the talos manager web didn't come up (the youtube video is wrong): https://www.youtube.com/watch?v=TCIkPvC9_ZA&t=8m38s

dbackeus commented 3 months ago

The two sections don't seem to make sense in this PR and I'm not sure why we're switching the order of the sections.

The minimal fix is to just add the heroku config:set HOST=$(heroku config:get HEROKU_APP_DEFAULT_DOMAIN_NAME) step to the heroku subdomain section right?

gunnars04 commented 3 months ago

The two sections don't seem to make sense in this PR and I'm not sure why we're switching the order of the sections.

Because: heroku labs:enable runtime-dyno-metadata will give us the HEROKU_APP_DEFAULT_DOMAIN_NAME

And HOST has to be equal to HEROKU_APP_DEFAULT_DOMAIN_NAME or this won't work.

Disclaimer: I haven't ran my fix from scratch, but updating HOST (when following the youtube was projectname.herokuapp.com) to be the value of HEROKU_APP_DEFAULT_DOMAIN_NAME (projectname-randomguid.herokuapp.com) was the fix.

The minimal fix is to just add the heroku config:set HOST=$(heroku config:get HEROKU_APP_DEFAULT_DOMAIN_NAME) step to the heroku subdomain section right?

Correct. I've updated the PR to do just that.

gunnars04 commented 3 months ago

creating another one