Optimize bit manipulation functions in utils.ts (#7) - Githubissues

reclaimprotocol / zk-symmetric-crypto

A circom library for zero-knowledge proofs of symmetric encryption key ownership without key revelation.

6 stars 3 forks source link

Optimize bit manipulation functions in utils.ts (#7) #11

Closed srimur closed 5 days ago

srimur commented 1 week ago

Description

Optimizes several bit manipulation functions in utils.ts by leveraging more efficient data structures, such as TypedArrays and DataView. This refactor improves performance without altering functionality. Key changes include:

Reduced loops by minimizing redundant computations.
Utilization of DataView to access memory more efficiently.
Maintained original behavior to ensure the same outputs as before.

Testing

Benchmarked the optimized version against the original implementation using console.time() and performance.now().
Verified correctness by running all existing tests to ensure outputs match the expected results.
Manually tested edge cases to ensure padding and bit conversion functions work correctly.

Type of change

[x] New feature
[ ] Bug fix
[ ] Breaking change
[ ] Documentation update

Checklist

[x] I have read and agree to the Code of Conduct.
[x] I have signed the Contributor License Agreement (CLA).
[x] I have considered the Security Policy.
[x] I have self-reviewed and tested my code.
[ ] I have updated documentation as needed.
[x] I agree to the project's custom license.

Additional Notes

The optimizations aim to improve efficiency without changing the API or behavior, making them fully backward-compatible.
All relevant test cases pass, ensuring no breaking changes were introduced.

CLAassistant commented 1 week ago

All committers have signed the CLA.