search

recloudstream / cloudstream

Android app for streaming and downloading media.
GNU General Public License v3.0
6.79k stars 544 forks source link

replace facebook shimmer library with updated volo fork with fixes #1318

Closed IndusAryan closed 3 weeks ago

C10udburst commented 2 months ago

not quite sure how relevant this one fix is?

https://github.com/facebookarchive/shimmer-android/compare/main...volo-droid:shimmer-android:main

IndusAryan commented 2 months ago

https://github.com/facebookarchive/shimmer-android/issues/133

the fork actually contains many fixes from original dev branch that were never merged and released and archived.

fire-light42 commented 3 weeks ago

I dont see anything substantial in https://github.com/facebookarchive/shimmer-android/compare/0.5.0...volo-droid:shimmer-android:main to warrant an update to a non trusted maintainer. As such I will be closing this as the "bugs" that are fixed where also the ones that was introduced after 0.5.0.