recmo / uint

Rust Uint crate using const-generics
MIT License
170 stars 39 forks source link

fix: modify `overflowing_shr` to fix overflow check #347

Closed tcoratger closed 6 months ago

tcoratger commented 8 months ago

Motivation

overflowing_shr algorithm seems to give incorrect overflow results: #337.

Should close #337.

Solution

This enhancement improves the functionality of the overflowing_shr method, providing a mechanism to determine whether the result represents a floating-point or integer value.

PR Checklist

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.57%. Comparing base (4f2b31d) to head (c9f9fa4).

:exclamation: Current head c9f9fa4 differs from pull request most recent head 0e515e0. Consider uploading reports for the commit 0e515e0 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #347 +/- ## ========================================== + Coverage 79.45% 79.57% +0.12% ========================================== Files 55 55 Lines 5578 5666 +88 ========================================== + Hits 4432 4509 +77 - Misses 1146 1157 +11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

prestwich commented 6 months ago

this change has been published in v1.12.0 thanks!