Closed tcoratger closed 6 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 79.57%. Comparing base (
4f2b31d
) to head (c9f9fa4
).:exclamation: Current head c9f9fa4 differs from pull request most recent head 0e515e0. Consider uploading reports for the commit 0e515e0 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
this change has been published in v1.12.0 thanks!
Motivation
overflowing_shr
algorithm seems to give incorrect overflow results: #337.Should close #337.
Solution
overflow
is set totrue
, indicating a floating-point result.overflowing_shr
function to differentiate between floating-point and integer outcomes after the shift operation.This enhancement improves the functionality of the
overflowing_shr
method, providing a mechanism to determine whether the result represents a floating-point or integer value.PR Checklist