recodehive / machine-learning-repos

A curated list of awesome machine learning frameworks, libraries and software (by language). I
https://machine-learning-repos.vercel.app/
MIT License
103 stars 194 forks source link

added task by vivek #1171

Closed aditya-bhaumik closed 2 weeks ago

aditya-bhaumik commented 2 weeks ago

@sanjay-kv

github-actions[bot] commented 2 weeks ago

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

shreyash3087 commented 2 weeks ago

@vivekvardhan2810 @aditya-bhaumik why is it static? and what does the progress bar mean? "5/10 closed" what?

vansh-codes commented 2 weeks ago

@vivekvardhan2810 @aditya-bhaumik I guess writing 34/34 will work or to give more details 34/34 done would also work There's no need for 34 closed / 34 done according to me.. What say @shreyash3087 ??

aditya-bhaumik commented 2 weeks ago

@vansh-codes no it will not look nice

vansh-codes commented 2 weeks ago

okay @aditya-bhaumik @vivekvardhan2810 ✅

aditya-bhaumik commented 2 weeks ago

@shreyash3087 its static because all of the projects are done so all are 10/10 or 20/20 which is 100 percent and i dont think new issues will be added as for the extra cards we added them because all the cards had 100 which was not looking good

So added a 2 - 3 50 percent also

MastanSayyad commented 2 weeks ago

@aditya-bhaumik @vivekvardhan2810, you both work on this together as co-authors right? I only see Vivek’s commits with code additions and @aditya-bhaumik’s three deletions of "empty space". Did you discuss the code and collaborate, with Vivek making the actual code changes? Or is this just for the badge purpose?

aditya-bhaumik commented 2 weeks ago

Yes @MastanSayyad

aditya-bhaumik commented 2 weeks ago

@MastanSayyad check the issue once which was assigned to vivek once and we both already have the badge

You can just do gmeet through whatsapp with the person you are collabrating makes the work so much easier

aditya-bhaumik commented 2 weeks ago

@MastanSayyad both of us worked on it together should not matter who made the commit

MastanSayyad commented 2 weeks ago

Yeah, no worries! Was just curious as it was static.