recolic / gnome-keyring-yubikey-unlock

This is a read-only mirror for https://git.recolic.net/root/gnome-keyring-yubikey-unlock
GNU General Public License v3.0
77 stars 5 forks source link

chmod 600 /path/to/your_secret #8

Closed danyeaw closed 2 years ago

danyeaw commented 2 years ago

A couple of recommendation, and I can submit a PR if this makes sense:

  1. Make /path/to/your_secret your $HOME/.gnupg folder. This helps ensure that it has the right permissions as a location along since we are already encrypting/decrypting with gpg
  2. chmod 600 /path/to/your_secret so that other users can't access it

I thought these changes to the README would help new users who might not know about file permissions.

recolic commented 2 years ago

No I don't think it's necessary... The user should know what he is doing, and making a long README even longer would confuse these Linux newbies...

Jan 25, 2022 10:18:22 Dan Yeaw @.***>:

A couple of recommendation, and I can submit a PR if this makes sense:

  1. Make /path/to/your_secret your $HOME/.gnupg folder. This helps ensure that it has the right permissions as a location along since we are already encrypting/decrypting with gpg

  2. chmod 600 /path/to/your_secret so that other users can't access it

I thought these changes to the README would help new users who might not know about file permissions.

— Reply to this email directly, view it on GitHub[https://github.com/recolic/gnome-keyring-yubikey-unlock/issues/8], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AEVTVEBESWV63247ZB3ARKTUXYB55ANCNFSM5MW745QA]. Triage notifications on the go with GitHub Mobile for iOS[https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675] or Android[https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub]. You are receiving this because you are subscribed to this thread. [data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAFQAAABUCAYAAAAcaxDBAAAAAXNSR0IArs4c6QAAAARzQklUCAgICHwIZIgAAAAySURBVHic7cEBDQAAAMKg909tDjegAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAeDVulAABbzDScQAAAABJRU5ErkJggg==###24x24:true###][Tracking image][https://github.com/notifications/beacon/AEVTVEBFENGG5JFCQOZMLR3UXYB55A5CNFSM5MW745QKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4QS4J24A.gif]

danyeaw commented 2 years ago

Alright, understand your point of view :+1: