recommenders-team / recommenders

Best Practices on Recommendation Systems
https://recommenders-team.github.io/recommenders/intro.html
MIT License
19.28k stars 3.11k forks source link

[BUG] #1924

Closed yustiks closed 1 year ago

yustiks commented 1 year ago

Description

The fastapi requires basic_train, which is not supported

In which platform does it happen?

Mac OS Ventura 13.2

How do we replicate the issue?

Run Jupyter notebook in google colab: https://github.com/microsoft/recommenders/blob/main/examples/06_benchmarks/movielens.ipynb

Expected behavior (i.e. solution)

Should run as shown in the initial draft

Other Comments

---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
[<ipython-input-2-157a955fe09e>](https://1e10pdw225c-496ff2e9c6d22116-0-colab.googleusercontent.com/outputframe.html?vrz=colab-20230419-060138-RC00_525408879#) in <cell line: 35>()
     36     from recommenders.utils.gpu_utils import get_cuda_version, get_cudnn_version
     37     from recommenders.models.fastai.fastai_utils import hide_fastai_progress_bar
---> 38     hide_fastai_progress_bar()
     39 except ImportError:
     40     pass  # skip this import if we are not in a GPU environment

[/usr/local/lib/python3.9/dist-packages/recommenders/models/fastai/fastai_utils.py](https://1e10pdw225c-496ff2e9c6d22116-0-colab.googleusercontent.com/outputframe.html?vrz=colab-20230419-060138-RC00_525408879#) in hide_fastai_progress_bar()
     78     fastprogress.fastprogress.WRITER_FN = str
     79     master_bar, progress_bar = force_console_behavior()
---> 80     fastai.basic_train.master_bar, fastai.basic_train.progress_bar = (
     81         master_bar,
     82         progress_bar,

AttributeError: module 'fastai' has no attribute 'basic_train'
miguelgfierro commented 1 year ago

We are not officially supporting Mac at the moment. If there is a problem in the deps in Mac, you will need to figure out the combination.

If this is a blocker, I would probably remove the progress bar function, it is just a nice to have feature.