search

recommenders-team / recommenders

Best Practices on Recommendation Systems
https://recommenders-team.github.io/recommenders/intro.html
MIT License
18.81k stars 3.07k forks source link

[BUG] Review GeoIMC movielens #1943

Open miguelgfierro opened 1 year ago

miguelgfierro commented 1 year ago

Description

When installing with pip install .[all], there is an error that pymanot is not installed.

After installing the latest version of pymaopt: 2.1.1, We got an error:

---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
Input In [1], in <cell line: 10>()
      8 from recommenders.datasets import movielens
      9 from recommenders.models.geoimc.geoimc_data import ML_100K
---> 10 from recommenders.models.geoimc.geoimc_algorithm import IMCProblem
     11 from recommenders.models.geoimc.geoimc_predict import Inferer
     12 from recommenders.evaluation.python_evaluation import (
     13     rmse, mae
     14 )

File ~/MS/recommenders/recommenders/models/geoimc/geoimc_algorithm.py:14, in <module>
     12 from pymanopt import Problem
     13 from pymanopt.manifolds import Stiefel, Product, SymmetricPositiveDefinite
---> 14 from pymanopt.solvers import ConjugateGradient
     15 from pymanopt.solvers.linesearch import LineSearchBackTracking
     18 class IMCProblem(object):

ModuleNotFoundError: No module named 'pymanopt.solvers'

In which platform does it happen?

How do we replicate the issue?

Expected behavior (i.e. solution)

Other Comments

miguelgfierro commented 1 year ago

hey @pratikjawanpuria @bamdevm, it seems that pymanopt is being updated, the GeoIMC notebook needs a update with the latest deps. Do you think you could take a look?