recommenders-team / recommenders

Best Practices on Recommendation Systems
https://recommenders-team.github.io/recommenders/intro.html
MIT License
19.2k stars 3.1k forks source link

[FEATURE] Upgrade fastai to v2 #1992

Closed SimonYansenZhao closed 7 months ago

SimonYansenZhao commented 1 year ago

Description

fastai has breaking changes in v2, which makes the code in recommenders incompatible with fastai v2. For example, CollabDataBunch is removed in fastai v2.

Expected behavior with the suggested feature

It should be compatible with fastai v2 because fastai v1 is not maintained.

Other Comments

There are 3 repos related to fastai:

See also

miguelgfierro commented 7 months ago

@SimonYansenZhao do you think this issue is fixed?

SimonYansenZhao commented 7 months ago

@SimonYansenZhao do you think this issue is fixed?

Yes