search

recommenders-team / recommenders

Best Practices on Recommendation Systems
https://recommenders-team.github.io/recommenders/intro.html
MIT License
18.71k stars 3.06k forks source link

[FEATURE] Support `steps` to newsrec models #2044

Closed loomlike closed 1 month ago

loomlike commented 8 months ago

Description

Currently newsrec models only support epoch training and the smoke-tests with epoch = 1 take minutes for each notebook. With a simple tweak to base_model.fit(), we can introduce steps parameters that constraint the number of batches to train. Then, we can set steps = 1 to the smoke test which will expediate the test time.

Expected behavior with the suggested feature

Use steps = 1 to all the smoke tests of the newsrec models.

sumana-2705 commented 1 month ago

@loomlike @miguelgfierro Shall I work on this issue?

miguelgfierro commented 1 month ago

feel free

sumana-2705 commented 1 month ago

@miguelgfierro I have opened a pr, but most of the checks have failed. I am not able to understand what is the reason for it. Can you please explain me why it happens, so that I can correct those checks.

miguelgfierro commented 1 month ago

right now, we have a bug that prevents external contributors from running the tests. It is a security limit from MS. We need to find a workaround. See #1853

sumana-2705 commented 1 month ago

okayy, I understood. Thanks for your reply @miguelgfierro

anargyri commented 1 month ago

@loomlike @sumana-2705 should this issue be closed now?

sumana-2705 commented 1 month ago

Yeah, I guess It can be closed now