recommenders-team / recommenders

Best Practices on Recommendation Systems

https://recommenders-team.github.io/recommenders/intro.html

MIT License

18.71k stars 3.06k forks source link

Fix nightly test errors #2045

Closed loomlike closed 8 months ago

loomlike commented 8 months ago

Description

Fix nightly test errors

Related Issues

2041

2035

Checklist:

[x] I have followed the contribution guidelines and code style for this project.
[x] I have added tests covering my contributions.
[ ] I have updated the documentation accordingly.
[x] This PR is being made to staging branch and not to main branch.

loomlike commented 8 months ago

New commits fix functional test errors too. Only three functional tests, sasrec, benchmark_gpu and benchmark_cpu, are failing now:

SASREC's hit@10

E             Obtained: 0.3702
E             Expected: 0.4244 ± 5.0e-02

NCF's ndcg (from test_benchmark_movielens_gpu)

E             Obtained: [0.41627350482234177]
E             Expected: 0.382793 ± 5.0e-02

BPR's ndcg (from test_benchmark_movielens_cpu)

E             Obtained: [0.44499071687886577]
E             Expected: 0.094444 ± 5.0e-02

loomlike commented 8 months ago

New commits fix functional test errors too. Only three functional tests, sasrec, benchmark_gpu and benchmark_cpu, are failing now:

SASREC's hit@10
E             Obtained: 0.3702
E             Expected: 0.4244 ± 5.0e-02
NCF's ndcg (from test_benchmark_movielens_gpu)
E             Obtained: [0.41627350482234177]
E             Expected: 0.382793 ± 5.0e-02
BPR's ndcg (from test_benchmark_movielens_cpu)
E             Obtained: [0.44499071687886577]
E             Expected: 0.094444 ± 5.0e-02

fixed those issues.

miguelgfierro commented 8 months ago

this is great @loomlike, if the PR is ready, do you want to merge?