Closed loomlike closed 8 months ago
New commits fix functional test errors too. Only three functional tests, sasrec, benchmark_gpu and benchmark_cpu, are failing now:
SASREC's hit@10
E Obtained: 0.3702
E Expected: 0.4244 ± 5.0e-02
NCF's ndcg (from test_benchmark_movielens_gpu)
E Obtained: [0.41627350482234177]
E Expected: 0.382793 ± 5.0e-02
BPR's ndcg (from test_benchmark_movielens_cpu)
E Obtained: [0.44499071687886577]
E Expected: 0.094444 ± 5.0e-02
New commits fix functional test errors too. Only three functional tests, sasrec, benchmark_gpu and benchmark_cpu, are failing now:
SASREC's hit@10
E Obtained: 0.3702 E Expected: 0.4244 ± 5.0e-02
NCF's ndcg (from test_benchmark_movielens_gpu)
E Obtained: [0.41627350482234177] E Expected: 0.382793 ± 5.0e-02
BPR's ndcg (from test_benchmark_movielens_cpu)
E Obtained: [0.44499071687886577] E Expected: 0.094444 ± 5.0e-02
fixed those issues.
this is great @loomlike, if the PR is ready, do you want to merge?
Description
Fix nightly test errors
Related Issues
2041
2035
Checklist:
staging branch
and not tomain branch
.