recommenders-team / recommenders

Best Practices on Recommendation Systems

https://recommenders-team.github.io/recommenders/intro.html

MIT License

18.71k stars 3.06k forks source link

Correct MIND user behavior history construction #2054

Closed thaiminhpv closed 7 months ago

thaiminhpv commented 7 months ago

Description

This PR fixes #1258 - the construction of user behavior history when loading MIND data.

Changed from

history = [0] * (self.his_size - len(history)) + history[ : self.his_size ]

to

history = [0] * (self.his_size - len(history)) + history[ -self.his_size : ]

Related Issues

1258

References

https://github.com/recommenders-team/recommenders/issues/1258#issuecomment-1878878858

Checklist:

[x] I have followed the contribution guidelines and code style for this project.
[ ] I have added tests covering my contributions.
[ ] I have updated the documentation accordingly.
[x] This PR is being made to staging branch and not to main branch.

cc @yjw1029

SimonYansenZhao commented 7 months ago

@miguelgfierro The authentication issue from non-maintainers is still there. See the failing tests in this PR.

Screenshot 2024-01-09 at 00 10 11