search

recommenders-team / recommenders

Best Practices on Recommendation Systems
https://recommenders-team.github.io/recommenders/intro.html
MIT License
18.71k stars 3.06k forks source link

[BUG] Upgrade GitHub Action azure/login #2065

Closed SimonYansenZhao closed 5 months ago

SimonYansenZhao commented 6 months ago

Description

This bug report is just a reminder that azure/login should be upgraded once a newer version that resolves those issues is released in the future.

azure/login is a GitHub Action used in the testing of Recommenders: https://github.com/recommenders-team/recommenders/blob/310370b2a0fd3366bce264b9b007ad6d6af330e0/.github/actions/azureml-test/action.yml#L78-L81

However, recent testing logs warn about the Node.js 16 used in azure/login is deprecated (See also GitHub Actions: Transitioning from Node 16 to Node 20), and the pre execution is not supported. Screenshot 2024-02-20 at 09 39 00

There are also several issues reported in the GitHub repo of azure/login:

And the pre execution issue seems to be originated from https://github.com/actions/runner/issues/1478

In which platform does it happen?

GitHub Actions

How do we replicate the issue?

Those warnings appear on every testing logs.

Expected behavior (i.e. solution)

The warnings should be fixed.

Other Comments

Other GitHub Actions with similar issues have been upgraded:

See PR: Resolve issue #2018

SimonYansenZhao commented 6 months ago

Noticed that node.js version had been upgraded by https://github.com/Azure/login/pull/411, but no new release has been published yet.

SimonYansenZhao commented 5 months ago

Fixed in #1937