search

recommenders-team / recommenders

Best Practices on Recommendation Systems
https://recommenders-team.github.io/recommenders/intro.html
MIT License
18.89k stars 3.08k forks source link

[BUG] Migrate AzureML SDK from v1 to v2 #2066

Closed SimonYansenZhao closed 2 months ago

SimonYansenZhao commented 7 months ago

Description

The AzureML SDK used in the testing for Recommenders is of version v1 (named azureml-core): https://github.com/recommenders-team/recommenders/blob/310370b2a0fd3366bce264b9b007ad6d6af330e0/.github/actions/azureml-test/action.yml#L75-L77 https://github.com/recommenders-team/recommenders/blob/310370b2a0fd3366bce264b9b007ad6d6af330e0/tests/ci/azureml_tests/submit_groupwise_azureml_pytest.py#L42-L50

Although v1 is still supported, It's better to migrate to version v2 (named azure-ai-ml). See Upgrade to v2 -- Azure Machine Learning

In which platform does it happen?

Azure Machine Learning

How do we replicate the issue?

The SDK is used in all tests for Recommenders

Expected behavior (i.e. solution)

AzureML SDK needs to be upgraded from v1 to v2, and all code in tests/ci/azureml_tests/submit_groupwise_azureml_pytest.py needs to be rewritten using v2.

SimonYansenZhao commented 7 months ago

In addition, an unresolved issue with the AzureML SDK v1 affects the upgrade of Recommenders is mentioned at https://github.com/recommenders-team/recommenders/pull/1937#issuecomment-1585972791.

SimonYansenZhao commented 2 months ago

The following items need to be considered:

daviddavo commented 2 months ago

It EOLs in September 2025. While more than a year remains, perhaps migrating to v2 would make Python 3.12 support easier too.