recommenders-team / recommenders

Best Practices on Recommendation Systems
https://recommenders-team.github.io/recommenders/intro.html
MIT License
18.47k stars 3.04k forks source link

Catch import error separately for SUMModel #2077

Closed SimonYansenZhao closed 3 months ago

SimonYansenZhao commented 3 months ago

Description

This PR resolves the issue #2064. Because TensorFlow breaking changes make the code for SUMModel not work, so the tests relating to SUMModel are disabled, and import errors on SUMModel should be separately handled, otherwise, the imports following SUMModel (such as ImplicitCF) will not be run.

https://github.com/recommenders-team/recommenders/blob/96fe3cf13bdb83fe334e6d305b3e31aab5a3ce9f/tests/smoke/recommenders/recommender/test_deeprec_model.py#L10-L32

Related Issues

2064

Checklist: