Fix typo in README.md - Githubissues

recommenders-team / recommenders

Best Practices on Recommendation Systems

https://recommenders-team.github.io/recommenders/intro.html

MIT License

18.47k stars 3.04k forks source link

Fix typo in README.md #2109

Closed Kingston257 closed 1 month ago

Kingston257 commented 1 month ago

Description

Make the following grammatical corrections to line 97 of the README file:

"has into account" should be "takes into account".
"Riemannian conjugate gradients optimization" should be "Riemannian conjugate gradient optimization" (singular form).
"and following a geometric approach" should be "and follows a geometric approach".

Related Issues

None

References

Uhmm... Dictionary?

Checklist:

[ ] I have followed the contribution guidelines and code style for this project.
[ ] I have added tests covering my contributions.
[ ] I have updated the documentation accordingly.
[ ] I have signed the commits, e.g. git commit -s -m "your commit message".
[ ] This PR is being made to staging branch AND NOT TO main branch.

miguelgfierro commented 1 month ago

Thanks @Kingston257 for your first contribution, and congrats!

Btw, I have changed the target branch to staging, which is our development branch.