recommenders-team / recommenders

Best Practices on Recommendation Systems
https://recommenders-team.github.io/recommenders/intro.html
MIT License
18.47k stars 3.04k forks source link

Remove LightFM from core package #2122

Closed miguelgfierro closed 2 weeks ago

miguelgfierro commented 2 weeks ago

Description

It seems LightFM is not supported anymore. It is currently blocking the support of Python 3.12 #2097. @daviddavo even fixed the problem in their repo https://github.com/lyst/lightfm/pull/710 but there is no response from the maintainers.

Related Issues

2115

References

Checklist:

miguelgfierro commented 2 weeks ago
==================================== ERRORS ====================================
_ ERROR collecting tests/data_validation/recommenders/datasets/test_movielens.py _
tests/data_validation/recommenders/datasets/test_movielens.py:23: in <module>
    from recommenders.datasets.movielens import MockMovielensSchema
recommenders/datasets/movielens.py:585: in <module>
    class MockMovielensSchema(pa.SchemaModel):
E   AttributeError: module 'pandera' has no attribute 'SchemaModel'
______ ERROR collecting tests/unit/recommenders/tuning/test_ncf_utils.py _______
tests/unit/recommenders/tuning/test_ncf_utils.py:9: in <module>
    from recommenders.datasets.movielens import MockMovielensSchema
recommenders/datasets/movielens.py:580: in <module>
    @extensions.register_check_method(statistics=["columns"], supported_types=pd.DataFrame)
/azureml-envs/azureml_36d38bfe693878b2e954f559f4339221/lib/python3.11/site-packages/pandera/api/extensions.py:309: in register_check_method
    return register_check_wrapper(check_fn)
/azureml-envs/azureml_36d38bfe693878b2e954f559f4339221/lib/python3.11/site-packages/pandera/api/extensions.py:244: in register_check_wrapper
    raise ValueError(
E   ValueError: method with name 'unique_columns' already defined. Check methods must have a unique method name.