Changing Function Name to reflect new Tensorflow interface.

siyerp commented 1 month ago

Changed a function call name to reflect a more recent version of tensorflow.

Description

I changed .reset_states() to .reset_state().
I was getting an error along the lines of "'Mean' object has no attribute 'reset_states'." It seems that in a newer version of tensorflow, the function has been renamed to .reset_state.

Related Issues

References

Checklist:

[ x] I have followed the contribution guidelines and code style for this project.
[ ] I have added tests covering my contributions.
[ ] I have updated the documentation accordingly.
[ x] I have signed the commits, e.g. git commit -s -m "your commit message".
[ x] This PR is being made to staging branch AND NOT TO main branch.

miguelgfierro commented 1 month ago

@siyerp thanks for this.

Can you share what TF version are you using?

FYI @daviddavo

daviddavo commented 1 month ago

It doesn't appear in the changelog, but they changed it in 2.5.

2.5 has reset_state
2.4 has reset_states
Relevant TF Commit, which is available since v2.5.0-rc0

I ran the tests on my machine and they work

siyerp commented 1 month ago

@miguelgfierro I'm using Tensorflow 2.16, but even in the example notebook it says it's using Tensorflow 2.8, and according to to @daviddavo 's comment, even that should have had this issue.

miguelgfierro commented 4 weeks ago

Merging this.

Please @siyerp notice that https://github.com/recommenders-team/recommenders/issues/2111 is in the works. If you want to collaborate on this effort, please let me know

recommenders-team / recommenders