recommenders-team / recommenders

Best Practices on Recommendation Systems
https://recommenders-team.github.io/recommenders/intro.html
MIT License
19.12k stars 3.09k forks source link

Updated function signatures to comply with new tensorflow requirements #2146

Closed siyerp closed 2 months ago

siyerp commented 2 months ago

Description

I tried to run the sarsec notebook, but ran into issues because the function calls didn't comply with updated tensorflow requirements. I fixed the function calls so that they comply with updated requirements.

Related Issues

If you try running the sarsec notebook with a recent version of tensorflow, the training throws an error because tensorflow modules can only take non-tensor arguments if they are keyword arguments, so the 'training' argument, which is a boolean, throws an error unless it is a keyword argument.

References

<!--- References would be helpful to understand the changes. -->

Checklist:

siyerp commented 2 months ago

@miguelgfierro I'd be interested in collaborating.

miguelgfierro commented 2 months ago

@siyerp would you be able to join the next Monday meeting: Every Monday, we have a recurrent meeting, the time is 4.30-5pm (Central European Time): https://teams.microsoft.com/l/meetup-join/19%3acf53f267b15340de8867aa869ced4ed1%40thre[…]2c%22Oid%22%3a%22c798428d-eb18-456e-aed9-c2ecae3a8510%22%7d