[BUG]tests are failing.

recommenders-team / recommenders

Best Practices on Recommendation Systems

https://recommenders-team.github.io/recommenders/intro.html

MIT License

18.89k stars 3.07k forks source link

[BUG]tests are failing. #775

Closed wutaomsft closed 5 years ago

wutaomsft commented 5 years ago

Description

In which platform does it happen?

How do we replicate the issue?

Expected behavior (i.e. solution)

Other Comments

gramhagen commented 5 years ago

several issues going on here

master cpu is failing due to the nni smac issue @anargyri are you ok pushing the current staging solution to this to master? or are there changes we should make to the nni notebook?
master gpu is failing due to metrics discrepancy with xdeepfm - could be something we can fix with setting seeds, @loomlike is this something you have time to look into?
staging failures seem to be a temporary hiccup connecting to git. i queued them to rerun, so hopefully those will be fixed shortly

anargyri commented 5 years ago

I agree we should push staging until NNI fix the issue.

miguelgfierro commented 5 years ago

SAR issue is fixed. We still need to fix the issue with NNI https://github.com/microsoft/recommenders/issues/746

@loomlike I think you have a fix for the xdeepfm right? is this already in staging?

gramhagen commented 5 years ago

addressing the staging nni failure in #781

loomlike commented 5 years ago

Will take a look at xDeepFM one.

loomlike commented 5 years ago

Is xDeepFM test still failing? If so, please give me more context, i.e. would be nice to know specific test function names that fail. I don't see them from my machine or PRs.

miguelgfierro commented 5 years ago

I haven't seen it failing for a while, but not sure