search

recommenders-team / recommenders

Best Practices on Recommendation Systems
https://recommenders-team.github.io/recommenders/intro.html
MIT License
18.89k stars 3.07k forks source link

iterator doesn't support the input format of "FM"? #777

Closed fly12357 closed 5 years ago

fly12357 commented 5 years ago

Tensorflow version: 1.13.1 python 3.6.8

./xDeepFM/Recommenders/reco_utils/recommender/deeprec/IO/iterator.py

image

./xDeepFM/Recommenders/reco_utils/recommender/deeprec/deeprec_utils.py

image

It seems that there isn't an useful data iterator script for "FM" format input.

gramhagen commented 5 years ago

Hi @fly12357 can you provide a bit more detail where this issue is occurring, what platform, what part of the code? And what the expected behavior is? This will help us debug and address what's happening.

fly12357 commented 5 years ago

Hi @fly12357 can you provide a bit more detail where this issue is occurring, what platform, what part of the code? And what the expected behavior is? This will help us debug and address what's happening.

It seems that there isn't an useful data iterator script for "FM" format input.

I modify the "deeprec_utils.py" as below. and change the "FM" format input file to "FFM" format (each feature with a unique field) to solve this problem.

image

gramhagen commented 5 years ago

Revisiting this, from looking at the script it seems like the final else clause should be catching the case where model_type == "FM", not the first case. Perhaps there's a discrepancy in your configuration where model_type and data_format are not both "FM"?

I will close it for now, but if this is still an issue let us know how to reproduce it.