search

recommenders / rival

RiVal recommender system evaluation toolkit
rival.recommenders.net
Apache License 2.0
150 stars 40 forks source link

Set correct path to ML data file #110

Closed franciscrimmins closed 9 years ago

franciscrimmins commented 9 years ago

The code in the net.recommenders.rival.examples.movielens100k examples downloads the ml-100k.zip file into the data/ml-100k directory, and then unzips it, resulting in the data being in data/ml-100k/ml-100k.

However, in the call to the prepareSplits() method the path to the input file is specified as data/ml-100k/u.data, which results in a NullPointerException when it tries to read from this non-existent file.

This minimal change is to specify the correct path to the input file in these source files.

I was running this on OS X, so I don't know whether the behavior of the unzipping code is perhaps different on that platform vs. others.

abellogin commented 9 years ago

Thank you, @franciscrimmins, for the patch. I will try it on my machine in the next few days and see if the error is reproduced. In that case, I will merge your commits.

abellogin commented 9 years ago

The error also happens in my machine, so I will merge your commits and check again.

abellogin commented 9 years ago

Checked, everything works. Thank you, @franciscrimmins!