recommenders / rival

RiVal recommender system evaluation toolkit

rival.recommenders.net

Apache License 2.0

150 stars 40 forks source link

IncrementalLeaveOneOutSplitter added #127

Closed andresmore closed 7 years ago

andresmore commented 7 years ago

Created this for one of my projects using 0.2. Adapted it for current way of handling data models. Hope it helps.

codecov-io commented 7 years ago

Codecov Report

Merging #127 into master will decrease coverage by 0.18%. The diff coverage is 0%.

@@            Coverage Diff            @@
##           master    #127      +/-   ##
=========================================
- Coverage   15.59%   15.4%   -0.19%     
=========================================
  Files          80      81       +1     
  Lines        4585    4640      +55     
  Branches      784     794      +10     
=========================================
  Hits          715     715              
- Misses       3803    3858      +55     
  Partials       67      67

Impacted Files	Coverage Δ
...l/split/splitter/IterativeLeaveOneOutSplitter.java	`0% <0%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update adc92e2...7711833. Read the comment docs.

alansaid commented 7 years ago

Thanks for the pull request @andresmore!

From a quick glance, it looks good! There are a few things that need to be implemented before merging it into the master:

please remove unnecessary newlines, e.g. 78-80, 85-86, etc.
fix indentation isses, e.g. lines 77-87, etc., etc.

Add the copyright statement below to the top of the class

/*
* Copyright 2017 recommenders.net.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
*      http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

alansaid commented 7 years ago

thanks @andresmore!