reconcilerio / dies

immutable, fluent, builders for Kubernetes resources
Apache License 2.0
8 stars 4 forks source link

Can be imported as `reconciler.io/dies` #133

Closed mamachanko closed 6 months ago

mamachanko commented 7 months ago

Dies cannot be imported as reconciler.io/dies yet:

❯ go mod init github.com/mamachanko/use-dies
go: creating new go.mod: module github.com/mamachanko/use-dies

❯ go get reconciler.io/dies
go: unrecognized import path "reconciler.io/dies": parse https://reconciler.io/dies?go-get=1: no go-import meta tags (meta tag reconciler.io/runtime did not match import path reconciler.io/dies, meta tag dies.dev did not match import path reconciler.io/dies)

We should follow-up with a change similar to https://github.com/reconcilerio/runtime/releases/tag/v0.20.0 which adjusts the import path etc.

scothis commented 7 months ago

No change is required as dies.dev continues to work.

mamachanko commented 7 months ago

Yes, but I thought - and I might be mistaken here - that there could be consistent "branding" across reconcilerio's projects when their import paths share the top-level reconciler.io, wouldn't you think?

scothis commented 7 months ago

We certainly could, but it would force all users to migrate to a longer package name. For runtime, the name change was unavoidable since it used the vmware-labs GitHub org as the name.

mamachanko commented 7 months ago

I understand! 👍🏻

Let's keep this open as to consider it eventually, unless you rule it out categorically.

scothis commented 7 months ago

Not ruling it out, as I do like symmetry.

scothis commented 6 months ago

done. Released as v0.11.0

mamachanko commented 6 months ago
❯ mkdir tmp

❯ cd tmp

❯ go mod init github.com/mamachanko/use-dies
go: creating new go.mod: module github.com/mamachanko/use-dies

❯ go get reconciler.io/dies
go: downloading reconciler.io/dies v0.11.0
go: added reconciler.io/dies v0.11.0

🎉