search

reconcilerio / dies

immutable, fluent, builders for Kubernetes resources
Apache License 2.0
8 stars 4 forks source link

Seal dies to enable diff and patch operations #142

Closed scothis closed 4 months ago

scothis commented 5 months ago

DieSeal stashes the current value of the die for later use in DieDiff and DiePatch operations. DieDiff use cmp.Diff to generate a textual diff of changes made to the die since it was seeled. DiePatch generates patch bytes to go from the seeled to current value.

scothis commented 5 months ago

Need to add tests and attempt to minimize new packages introduced.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 67.18750% with 21 lines in your changes missing coverage. Please review.

Project coverage is 10.78%. Comparing base (b4c0177) to head (f715874).

Files Patch % Lines
patch/patch.go 72.00% 6 Missing and 1 partial :warning:
patch/json/json.go 53.84% 3 Missing and 3 partials :warning:
patch/merge/merge.go 60.00% 2 Missing and 2 partials :warning:
patch/strategicmerge/strategicmerge.go 60.00% 2 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #142 +/- ## ========================================= + Coverage 9.71% 10.78% +1.06% ========================================= Files 69 74 +5 Lines 3221 3283 +62 ========================================= + Hits 313 354 +41 - Misses 2905 2918 +13 - Partials 3 11 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mamachanko commented 5 months ago

@scothis shouldn't it be DieSeal? Unless you actually mean to say "seel", which would make sense as well. https://www.merriam-webster.com/dictionary/seel