scothis commented 2 years ago

Previously, about half of the Add*() methods that set a value in a map checked if the map was nil before setting a field. Now they all do.

Resolves #66

Signed-off-by: Scott Andrews scott@andrews.me

scothis commented 2 years ago

cc @mamachanko

codecov[bot] commented 2 years ago

Codecov Report

Merging #67 (cebc5ed) into main (04e5dfa) will decrease coverage by 0.12%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
- Coverage   10.58%   10.45%   -0.13%     
==========================================
  Files          64       64              
  Lines        3024     3060      +36     
==========================================
  Hits          320      320              
- Misses       2702     2738      +36     
  Partials        2        2

Impacted Files	Coverage Δ
apis/core/v1/container.go	`0.00% <0.00%> (ø)`
apis/core/v1/limitrange.go	`0.00% <0.00%> (ø)`
apis/core/v1/node.go	`0.00% <0.00%> (ø)`
apis/core/v1/persistantvolume.go	`0.00% <0.00%> (ø)`
apis/core/v1/persistantvolumeclaim.go	`0.00% <0.00%> (ø)`
apis/core/v1/pod.go	`26.77% <0.00%> (-0.30%)`	:arrow_down:
apis/core/v1/resourcequota.go	`0.00% <0.00%> (ø)`
apis/core/v1/service.go	`0.00% <0.00%> (ø)`
apis/node/v1/runtimeclass.go	`0.00% <0.00%> (ø)`
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

reconcilerio / dies

Initialize nil maps before setting key #67

Codecov Report