search

reconciliation-api / specs

Specifications of the reconciliation API
https://reconciliation-api.github.io/specs/draft/
31 stars 9 forks source link

Add Accept-Language and Content-Language headers #108

Closed wetneb closed 1 year ago

wetneb commented 1 year ago

For #52.

There seems to be interest in #52 to have more than that: also introduce parameters in the queries to specify the language of the data. I am not too sure how useful that is and which form it should take (do you want to specify the language of each string in the query independently? should we follow JSON-LD conventions to represent strings with languages?) so I am leaving this for another PR.

wetneb commented 1 year ago

Given https://github.com/reconciliation-api/specs/issues/52#issuecomment-1558986118 I would propose to remove the Content-Language header.

fsteeg commented 1 year ago

I've commented in https://github.com/reconciliation-api/specs/issues/52#issuecomment-1593256325, I still think this PR is good as it is, but let's wait for feedback from @VladimirAlexiev over there.